Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplifying handleKey function #450

Merged
merged 2 commits into from
Sep 17, 2015
Merged

simplifying handleKey function #450

merged 2 commits into from
Sep 17, 2015

Conversation

davidpene
Copy link

Details:

  • removing top call to preventDefault
  • adding break when backspace, as preventDefault is called at the bottom of function

cc: @JedWatson

@JedWatson
Copy link
Owner

Good call, cheers @davidpene

JedWatson added a commit that referenced this pull request Sep 17, 2015
@JedWatson
Merge pull request #450 from davidpene/master
902093f 
simplifying handleKey function
@JedWatson JedWatson merged commit 902093f into JedWatson:master Sep 17, 2015
This was referenced Mar 7, 2021
Open
Open
This was referenced Nov 5, 2022
Open
Open
This was referenced Dec 25, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidpene @JedWatson